Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add container environment for building and testing in CI #1569

Merged
merged 4 commits into from
Jul 10, 2023

Conversation

PragmaTwice
Copy link
Member

In this PR, we add a container environment (currently CentOS 7) for building and testing in CI.

It closes #795.

@PragmaTwice PragmaTwice requested review from git-hulk and tisonkun July 9, 2023 08:02
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the correct grammar is "in container". Generally looks good.

@PragmaTwice PragmaTwice added the A-ci area ci label Jul 10, 2023
@PragmaTwice PragmaTwice merged commit 943af5c into apache:unstable Jul 10, 2023
enjoy-binbin pushed a commit that referenced this pull request Aug 7, 2023
SUSE is a main linux distro branch, as well as Debian (Ubuntu), RHEL (CentOS).
So we can build and test kvrocks in a SUSE environment.

It is a successor to #1569. We can just implement the env based on it.
setup-go action in SUSE can trigger a failure, so it is replaced.

Closes #1578.
p1u3o pushed a commit to p1u3o/incubator-kvrocks that referenced this pull request Aug 15, 2023
)

SUSE is a main linux distro branch, as well as Debian (Ubuntu), RHEL (CentOS).
So we can build and test kvrocks in a SUSE environment.

It is a successor to apache#1569. We can just implement the env based on it.
setup-go action in SUSE can trigger a failure, so it is replaced.

Closes apache#1578.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ci area ci
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more linux distro environments in GitHub Actions
3 participants